Actually, at least in the English dub, Gui's nickname for Sushang is Shangshang. She calls her it during the ghost hunting and Wardance events, and if you go to the Voice Line "About Sushang" its the first thing she says.
If a Chinese name'form likes “AB”(A,B each one refers to a Chinese character(HanZi in Chinese,or Kanji in Japanese) And if it's a girl's name,we often use such “BB”or“B” as a nickname to show the close friendship between this two who are talking. So,like“Su(A)shang(B)”,the“ShangShang(BB)” is not a mistake,just the difference between cultures. (BTW,Her last name actually is Li(Lee,like Bruce Lee),Li Sushang )